jasonmolenda wrote:

I like this change, this will be a very handy capability for people debugging 
corefiles & live sessions on remote computers when they have a mechanism to 
find the binaries and/or debug info for those processes, without needing to 
download all of them. One change I would also roll in in  
`SymbolLocator::DownloadSymbolFileAsync()` is to request `copy_executable=true` 
here,

```
    if (!PluginManager::DownloadObjectAndSymbolFile(module_spec, error,
                                                    /*force_lookup=*/true,
                                                    /*copy_executable=*/false))
```

So we download both the dSYM and binary for situations where we don't have a 
local binary.

https://github.com/llvm/llvm-project/pull/80890
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to