bulbazord wrote: > LGTM! > > I see that we still have `FindAndReplaceIDRanges` referencing > CommandReturnObject; out of curiosity, have you had a chance to look into > removing that one (if it makes sense)? I see that `CommandReturnObject` is > neither `#include`ed nor forward declared in the header, so the code is very > much relying on others files to do either of those.
Yes, I planned on doing that in a follow-up. :) https://github.com/llvm/llvm-project/pull/77161 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits