https://github.com/cmtice created
https://github.com/llvm/llvm-project/pull/76171
TestGlobalModuleCache.py, a recently added test, tries to update a source file
in the build directory, but it assumes the file is writable. In our distributed
build and test system, this is not always true, so the test often fails with a
write permissions error.
This change fixes that by setting the permissions on the file to be writable
before attempting to write to it.
>From 74ac76e175917e0354d998b3b3fdc2b30bf9251b Mon Sep 17 00:00:00 2001
From: Caroline Tice <cmt...@google.com>
Date: Thu, 21 Dec 2023 09:10:35 -0800
Subject: [PATCH] [LLDB] Fix write permission error in TestGlobalModuleCache.py
TestGlobalModuleCache.py, a recently added test, tries to update
a source file in the build directory, but it assumes the file is
writable. In our distributed build and test system, this is not
always true, so the test often fails with a write permissions error.
This change fixes that by setting the permissions on the file to
be writable before attempting to write to it.
---
.../python_api/global_module_cache/TestGlobalModuleCache.py | 3 +++
1 file changed, 3 insertions(+)
diff --git
a/lldb/test/API/python_api/global_module_cache/TestGlobalModuleCache.py
b/lldb/test/API/python_api/global_module_cache/TestGlobalModuleCache.py
index 6bb22c46efb443..02b77310b0067b 100644
--- a/lldb/test/API/python_api/global_module_cache/TestGlobalModuleCache.py
+++ b/lldb/test/API/python_api/global_module_cache/TestGlobalModuleCache.py
@@ -26,6 +26,9 @@ def copy_to_main(self, src, dst):
# a previous build, so sleep a bit here to ensure that the touch is
later.
time.sleep(2)
try:
+ # Make sure dst is writeable before trying to write to it.
+ subprocess.run(['chmod', '777', dst], stdin=None,
+ capture_output=False, encoding='utf-8')
shutil.copy(src, dst)
except:
self.fail(f"Could not copy {src} to {dst}")
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
