jimingham wrote:

It came from the test case I copied to this one but wasn't appropriate.  Should 
have been deleted, not commented out.

Jim

> On Dec 13, 2023, at 3:44 PM, Adrian Prantl ***@***.***> wrote:
> 
> 
> @adrian-prantl commented on this pull request.
> 
> In lldb/test/API/python_api/global_module_cache/TestGlobalModuleCache.py 
> <https://github.com/llvm/llvm-project/pull/74894#discussion_r1425997651>:
> 
> > +"""
> +Test the use of the global module cache in lldb
> +"""
> +
> +import lldb
> +
> +from lldbsuite.test.decorators import *
> +from lldbsuite.test.lldbtest import *
> +from lldbsuite.test import lldbutil
> +import os
> +import shutil
> +from pathlib import Path
> +import time
> +
> +class GlobalModuleCacheTestCase(TestBase):
> +    # NO_DEBUG_INFO_TESTCASE = True
> why is this commented out?
> 
> —
> Reply to this email directly, view it on GitHub 
> <https://github.com/llvm/llvm-project/pull/74894#pullrequestreview-1780665194>,
>  or unsubscribe 
> <https://github.com/notifications/unsubscribe-auth/ADUPVW5HJ4E4Y4VARD3P7UTYJI4VNAVCNFSM6AAAAABANJIUI2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOBQGY3DKMJZGQ>.
> You are receiving this because you modified the open/close state.
> 



https://github.com/llvm/llvm-project/pull/74894
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to