=?utf-8?q?José?= L. Junior <josejun...@10xengineers.ai> Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/69...@github.com>
DavidSpickett wrote: Please go through the unresolved comments and reply if you feel that you've done them, or ask questions if they don't make sense (I know Github doesn't make this super easy, but scrolling through the changed files should show you most of them). >From here: * Please remove any commented out code, comments that are now obvious from reading the code, etc. * Rename `name` to `pattern`, it will be a 1000% less confusing for all of us :) * Make sure that `ninja check-lldb` has no failures. * clang-format your changes (https://clang.llvm.org/docs/ClangFormat.html) This is not an exhaustive list but with all that done I can give it a fresh look without distractions and we'll get this moving along toward final review. For clang-format here is a one liner I use, run from the `llvm-project` repo root: ``` git diff -U0 --no-color --relative HEAD^ | ./clang/tools/clang-format/clang-format-diff.py -p1 -i -b <path to llvm build>/bin/clang-format ``` If you want to keep your commit history you can interactive rebase (`git rebase -i`) and do this at each commit, adding any changes as you go. This is not super important now, but it does help me a little when reading the code, and it's something you'll need to know how to do for the final change in any case. Generally reviewers expect to see formatted code. https://github.com/llvm/llvm-project/pull/69422 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
