llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb <details> <summary>Changes</summary> Fixes misleading comment introduced in `f74aaca63202cabb512c78fe19196ff348d436a8` (https://github.com/llvm/llvm-project/pull/68300) --- Full diff: https://github.com/llvm/llvm-project/pull/68405.diff 1 Files Affected: - (modified) lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp (+2-2) ``````````diff diff --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp index 6e13626d2894313..d0065896b0d2292 100644 --- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp +++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp @@ -2878,8 +2878,8 @@ void DWARFASTParserClang::ParseSingleMember( attrs.accessibility = eAccessNone; // Handle static members, which are typically members without - // locations. However, GCC *never* emits DW_AT_data_member_location - // for static data members of unions. + // locations. However, GCC doesn't emit DW_AT_data_member_location + // for any union members (regardless of linkage). // Non-normative text pre-DWARFv5 recommends marking static // data members with an DW_AT_external flag. Clang emits this consistently // whereas GCC emits it only for static data members if not part of an `````````` </details> https://github.com/llvm/llvm-project/pull/68405 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
