jeffreytan81 wrote:

Looks good in general to me. 

Several scenarios to test:
* Make sure command works when the vtable symbol can be found but the vtable 
exists in another binary which do not have any symbols/debug info (which we 
have seen failure from lldb before)
* Is vtable pointer guarantee to be in the first pointer of object? 
* Can we test this during multiple inheritance? Should we print multiple 
vtables? 
* Test in coredump to make sure it works

https://github.com/llvm/llvm-project/pull/67599
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to