bulbazord added a comment. A few questions:
- Do all of these need to be protected with a mutex? In your description you're saying TSan is detecting data races. What piece of data are you observing the data race on? - Do we need a recursive mutex? I assume that these operations might call into each other, but if not it would be nice to just have it be a `std::mutex`. I think your implementation is already correct, these questions are more geared towards performance (i.e. not locking more than we need to, using a more efficient mutex type, etc.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157041/new/ https://reviews.llvm.org/D157041 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
