bulbazord added a comment. It would be nice if we could clean up what `mode` is. There's a lot of bit-wise operations and setting it to 1 and 2 and it's not clear what each one might mean in each case... Some kind of enum or semantic meaning for each number would be nice. Either way, I think I'm on board with the logic in general. Just one question though.
================ Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:303 + return false; + count = llvm::popcount(bitfield); + break; ---------------- This clobbers the previously set `count` on line 294. What of that `count`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157022/new/ https://reviews.llvm.org/D157022 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
