Author: Jonas Devlieghere Date: 2023-07-30T14:24:50-07:00 New Revision: 7963aa13ac062f11ac05e024eb53adb8fae0bef9
URL: https://github.com/llvm/llvm-project/commit/7963aa13ac062f11ac05e024eb53adb8fae0bef9 DIFF: https://github.com/llvm/llvm-project/commit/7963aa13ac062f11ac05e024eb53adb8fae0bef9.diff LOG: [lldb] Remove inconsequential radar link (NFC) The comment after the radar link already explains the issue. There's no additional information in the radar and has been marked as closed by the corresponding code change. This commit removes the link and reflows the comment. Added: Modified: lldb/source/Target/Target.cpp Removed: ################################################################################ diff --git a/lldb/source/Target/Target.cpp b/lldb/source/Target/Target.cpp index ab68f447cfdb6f..3ce7871f707861 100644 --- a/lldb/source/Target/Target.cpp +++ b/lldb/source/Target/Target.cpp @@ -2864,12 +2864,12 @@ bool Target::RunStopHooks() { if (!any_active_hooks) return false; - // <rdar://problem/12027563> make sure we check that we are not stopped - // because of us running a user expression since in that case we do not want - // to run the stop-hooks. Note, you can't just check whether the last stop - // was for a User Expression, because breakpoint commands get run before - // stop hooks, and one of them might have run an expression. You have - // to ensure you run the stop hooks once per natural stop. + // Make sure we check that we are not stopped because of us running a user + // expression since in that case we do not want to run the stop-hooks. Note, + // you can't just check whether the last stop was for a User Expression, + // because breakpoint commands get run before stop hooks, and one of them + // might have run an expression. You have to ensure you run the stop hooks + // once per natural stop. uint32_t last_natural_stop = m_process_sp->GetModIDRef().GetLastNaturalStopID(); if (last_natural_stop != 0 && m_latest_stop_hook_id == last_natural_stop) return false; _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
