wallace added a comment. Could you split the changes to the selected thread out of this? I'm seeing two features being implemented in this patch. Other than that, it looks pretty good!
================ Comment at: lldb/tools/lldb-vscode/Options.td:20-38 +def port: S<"port">, MetaVarName<"<port>">, HelpText<"Communicate with the lldb-vscode tool over the defined port.">; def: Separate<["-"], "p">, Alias<port>, HelpText<"Alias for --port">; ---------------- +1 ================ Comment at: lldb/tools/lldb-vscode/VSCode.cpp:768 + return true; +} ---------------- use clang-format please ================ Comment at: lldb/tools/lldb-vscode/VSCode.h:89 + +/// A huersitic for determining the context of an evaluation. +enum class ExpressionContext { ---------------- typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154030/new/ https://reviews.llvm.org/D154030 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits