[Lldb-commits] [PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

[Haojian Wu via Phabricator via lldb-commits]

hokein added inline comments.


================
Comment at: lldb/tools/lldb-server/lldb-platform.cpp:112
     return Status("Failed to atomically write file %s",
                   file_spec.GetPath().c_str());
   return status;
----------------
avl wrote:
> probably, it would be better to add error text here?
> 
> ```
>     return Status("Failed to atomically write file %s: %s",
>                   file_spec.GetPath().c_str(), 
> toString(std::move(Err)).c_str());
> ```
good idea.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154329/new/

https://reviews.llvm.org/D154329

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits