splhack added inline comments.

================
Comment at: lldb/source/Plugins/Platform/Android/PlatformAndroid.cpp:261-264
+  if (const char *run_as = std::getenv("ANDROID_PLATFORM_RUN_AS"))
+    snprintf(run_as_cmd, sizeof(run_as_cmd), "run-as '%s' ", run_as);
+  else
+    run_as_cmd[0] = '\0';
----------------
splhack wrote:
> bulbazord wrote:
> > Maybe it would be a good idea to centralize the `run-as` logic somewhere, 
> > right now it's pretty ad-hoc.
> Will look into these run-as things with D152494 centralize and if 
> plugin.platform.android.platform-run-as possible.
run-as is centralized in D152933


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152759/new/

https://reviews.llvm.org/D152759

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to