mib added inline comments.
================ Comment at: lldb/source/Utility/Listener.cpp:214 } else { - pos = std::find_if(m_events.begin(), m_events.end(), - EventMatcher(broadcaster, event_type_mask)); + pos = std::find_if(m_events.begin(), m_events.end(), event_matcher); } ---------------- Since you used `llvm::erased_it` above, could you use `llvm::find_if` here as well to stay consistent. It will also make this line shorter since you can just pass the container instead of passing the beginning and ending iterators. ================ Comment at: lldb/source/Utility/Listener.cpp:372 + iter = + std::find_if(m_broadcaster_managers.begin(), end_iter, manager_matcher); if (iter == end_iter) ---------------- ditto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152846/new/ https://reviews.llvm.org/D152846 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits