kastiglione added inline comments.

================
Comment at: lldb/source/Core/ValueObjectDynamicValue.cpp:119-123
+    if (auto *runtime = llvm::dyn_cast_or_null<ObjCLanguageRuntime>(
+            process->GetLanguageRuntime(lldb::eLanguageTypeObjC)))
+      if (auto class_sp = runtime->GetClassDescriptor(valobj))
+        if (class_sp->IsSwift())
+          return true;
----------------
@bulbazord this is where it's used, to work with `ClassDescriptor` which is 
part of the `ObjCLanguageRuntime`. I don't think it would make sense to lift 
that into the generic `LangaugeRuntime`. What other courses might there be?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152837/new/

https://reviews.llvm.org/D152837

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to