beanz added inline comments.
================
Comment at: clang/test/ParserHLSL/group_shared.hlsl:14
-// expected-error@+1 {{expected expression}}
float groupshared [[]] i = 12;
----------------
philnik wrote:
> beanz wrote:
> > aaron.ballman wrote:
> > > philnik wrote:
> > > > Should this also get an extension warning/should attributes be disabled
> > > > for HLSL?
> > > CC @beanz
> > >
> > > I was wondering the same thing. :-)
> > By bug rather than design DXC allows C++ attribute syntax in some places
> > for HLSL.
> >
> > I'm totally fine with (and prefer) following the rest of the languages here
> > and having HLSL in Clang always allow C++ attributes regardless of language
> > version.
> Would you like some sort of warning?
Since DXC accepts the syntax without a warning/error I think we're fine without
one here. There won't be any portability issues with code that use C++
attributes in HLSL unless they go back to the _extremely_ old compiler that we
don't really support anyways.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151683/new/
https://reviews.llvm.org/D151683
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
