aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:889
+ "Package unit with a non-zero abbreviation offset");
+
+ auto *unit_contrib = index_entry->getContribution();
----------------
I know this was also in the original code, so you may not know either: Should
these error messages be limited to dwarf packages (.dwp) or should they be more
generic?
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:980
+ entry = index.getFromOffset(expected_header->GetOffset());
+ if (entry) {
+ if (llvm::Error err = expected_header->ApplyIndexEntry(entry)) {
----------------
llvm coding style would delete most of these {} ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151919/new/
https://reviews.llvm.org/D151919
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
