mib marked an inline comment as done.
mib added inline comments.
================
Comment at: lldb/examples/python/crashlog.py:493
self.images = list()
+ self.crashlog = CrashLog(debugger, self.path, self.verbose)
----------------
bulbazord wrote:
> Any reason you moved this?
It makes more sense to me to initialize the crashlog object last.
================
Comment at: lldb/examples/python/crashlog.py:1373-1374
+ arch = crashlog.process_arch
+ if not arch:
+ arch = platform.machine()
+ target = debugger.CreateTargetWithFileAndArch(None, arch)
----------------
bulbazord wrote:
> The fallback of "use the host platform's architecture" seems like it could
> lead to some issues no? I'm not sure we can do better if the crashlog doesn't
> have any info about a process architecture though...
Do you think we shouldn't fallback to the host architecture in this case and
raise an exception instead ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151849/new/
https://reviews.llvm.org/D151849
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
