mib marked an inline comment as done.
mib added inline comments.
================
Comment at: lldb/source/Commands/CommandObjectWatchpoint.cpp:959
", variable expression='%s').\n",
addr, (uint64_t)size, command.GetArgumentAtIndex(0));
if (error.AsCString(nullptr))
----------------
JDevlieghere wrote:
> You wouldn't need the `(uint64_t)` cast if you used formatv. This also should
> use a C++ style cast
> (https://discourse.llvm.org/t/rfc-add-preferred-casting-style-to-coding-standards/70793/4).
Good point, but this code was already here before my patch, I just moved around
to have early returns.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151366/new/
https://reviews.llvm.org/D151366
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
