[Lldb-commits] [PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

[Sergei Barannikov via Phabricator via lldb-commits]

barannikov88 added inline comments.


================
Comment at: clang/lib/AST/Type.cpp:2187
+             BT->getKind() <= BuiltinType::Ibm128 &&
+             BT->getKind() != BuiltinType::BF16;
   if (const auto *ET = dyn_cast<EnumType>(CanonicalType))
----------------
Looks like another clang-format quirk.



================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:5568
 
   bool allowBFloatArgsAndRet() const override {
+    return getTarget().hasBF16Type();
----------------
Should the name of the method be updated?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150291/new/

https://reviews.llvm.org/D150291

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits