jingham added inline comments.
================ Comment at: lldb/unittests/API/SBCommandInterpreterTest.cpp:24 SBDebugger::Initialize(); m_dbg = SBDebugger::Create(/*source_init_files=*/false); } ---------------- bulbazord wrote: > jingham wrote: > > It isn't clear to me how the changes in this file fit in with your overall > > goal? > I'm removing the `SBCommandInterpreter` member of this class because in order > to construct an object of this class, `SBCommandInterpreter` would need to > have an empty default constructor (which we do not have currently). I didn't > want to add a constructor for SBCommandInterpreter just to avoid changing the > test. Sounds reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150157/new/ https://reviews.llvm.org/D150157 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits