bulbazord accepted this revision.
bulbazord added a comment.
This revision is now accepted and ready to land.
I have no problem with removing mod_date since you're only removing the
requirement in the Darwin-specific code. Also, be sure to remove the portion of
the commit message that says this introduces a regression since you've fixed
the test now. It would be confusing for future code archeologists.
LGTM!
================
Comment at: lldb/tools/debugserver/source/MacOSX/MachProcess.mm:1141
}
- return FormatDynamicLibrariesIntoJSON(image_infos);
+ return FormatDynamicLibrariesIntoJSON(image_infos, true);
}
----------------
nit: Could you add a comment specifying what the bool argument is for?
```
return FormatDynamicLibrariesIntoJSON(image_infos, /* report_load_commands = */
true);
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150158/new/
https://reviews.llvm.org/D150158
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
