aprantl added inline comments.
================ Comment at: lldb/include/lldb/lldb-enumerations.h:493 eLanguageTypeAda2012 = 0x002f, + eLanguageTypeMojo = 0x0030, ---------------- bulbazord wrote: > These values correspond to DWARF5's official language codes and `0x0030` is > technically already taken. LLDB just hasn't been updated yet. I don't think > this should necessarily block this patch but this value will need to be > changed at some point. > > See: https://dwarfstd.org/languages.html Registering a new language with the DWARF committee is a pretty quick process nowadays. Please do that before taking a constant in the reserved range. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149702/new/ https://reviews.llvm.org/D149702 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
