sgraenitz added a comment.

In D146058#4305046 <https://reviews.llvm.org/D146058#4305046>, @labath wrote:

> That's not entirely what I was referring to. What I fear is the following 
> situation. A random developer makes a random patch that happens to break 
> gnustep support. That developer cannot debug that issue locally (cannot or 
> doesn't know how to build gnustep from source), so someone has to help him 
> figure out the problem. I don't want to be the person doing that. :)

Yes, that's reasonable. In my last patch, I already changed the default to 
`Off`.



================
Comment at: lldb/test/CMakeLists.txt:29
+# Windows and Linux have no built-in ObjC runtime. Turn this on in order to 
run tests with GNUstep.
+option(LLDB_TEST_OBJC_GNUSTEP "Enable ObjC tests with GNUstep libobjc2 on 
non-Apple platforms" Off)
+set(LLDB_TEST_OBJC_GNUSTEP_DIR "" CACHE PATH "Custom path to the GNUstep 
shared library")
----------------
See here, `Off` by default


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146058/new/

https://reviews.llvm.org/D146058

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to