bulbazord added a comment.

In D149262#4306884 <https://reviews.llvm.org/D149262#4306884>, @kuilpd wrote:

> In D149262#4306820 <https://reviews.llvm.org/D149262#4306820>, @bulbazord 
> wrote:
>
>> Sorry I should have brought this up earlier but I've noticed you don't have 
>> any tests with this change. Is it possible you could add something there? 
>> Something to make sure that these settings work as expected.
>
> Should I do it also without a target?

It's probably enough to just add a test with a target, the settings shouldn't 
mess with the non-target case I think.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149262/new/

https://reviews.llvm.org/D149262

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to