This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGdc275fd03254: [lldb/crashlog] Fix JSON ObjectFile module
loading issue (authored by mib).
Changed prior to commit:
https://reviews.llvm.org/D149477?vs=518022&id=518025#toc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149477/new/
https://reviews.llvm.org/D149477
Files:
lldb/examples/python/symbolication.py
Index: lldb/examples/python/symbolication.py
===================================================================
--- lldb/examples/python/symbolication.py
+++ lldb/examples/python/symbolication.py
@@ -401,6 +401,11 @@
with open(tf.name, 'w') as f:
f.write(json.dumps(data, indent=4))
self.module = target.AddModule(tf.name, None, uuid_str)
+ if self.module:
+ # If we were able to add the module with inlined
+ # symbols, we should mark it as available so
load_module
+ # does not exit early.
+ self.unavailable = False
if not self.module and not self.unavailable:
return 'error: unable to get module for (%s) "%s"' % (
self.arch, self.get_resolved_path())
Index: lldb/examples/python/symbolication.py
===================================================================
--- lldb/examples/python/symbolication.py
+++ lldb/examples/python/symbolication.py
@@ -401,6 +401,11 @@
with open(tf.name, 'w') as f:
f.write(json.dumps(data, indent=4))
self.module = target.AddModule(tf.name, None, uuid_str)
+ if self.module:
+ # If we were able to add the module with inlined
+ # symbols, we should mark it as available so load_module
+ # does not exit early.
+ self.unavailable = False
if not self.module and not self.unavailable:
return 'error: unable to get module for (%s) "%s"' % (
self.arch, self.get_resolved_path())
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
