jwnhy marked an inline comment as done.
jwnhy added inline comments.

================
Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/DW_OP_div-with-signed.s:3
+
+  # RUN: %clang --target=x86_64-pc-linux -o %t %s
+  # RUN: %lldb %t -o "b f" -o "r" -o "c" -o "c" -o "expression -T -- i" \
----------------
Michael137 wrote:
> other tests use `llvm-mc` as the assembler
> E.g., `llvm-mc -filetype=obj -o %t -triple x86_64-pc-linux %s`
> 
> I think it'll marginally speed things up
There are some issues on llvm-mc, it complains about .loc directives.
So I guess I will just go with Clang...


================
Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/DW_OP_div-with-signed.s:6
+  # RUN: -o "exit" | FileCheck %s
+
+  # Failing case was:
----------------
Michael137 wrote:
> Can you paste the source code here which you used to derive this test case? 
> For future readers
Update the patch to include the original sources.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147370/new/

https://reviews.llvm.org/D147370

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to