JDevlieghere added a comment.
LGTM but I'll hold off on accepting to give Alex a change to take another look
as he had more significant comments.
================
Comment at: lldb/source/Interpreter/ScriptInterpreter.cpp:78-91
lldb::DataExtractorSP
ScriptInterpreter::GetDataExtractorFromSBData(const lldb::SBData &data) const {
return data.m_opaque_sp;
}
+lldb::BreakpointSP ScriptInterpreter::GetOpaqueTypeFromSBBreakpoint(
+ const lldb::SBBreakpoint &breakpoint) const {
----------------
NTBF for this patch but we should really be using templates here to avoid code
duplication.
================
Comment at:
lldb/source/Plugins/ScriptInterpreter/Python/ScriptedProcessPythonInterface.cpp:124
+ if (!CheckStructuredDataObject(LLVM_PRETTY_FUNCTION, obj, error))
+ return {};
+
----------------
return false
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148548/new/
https://reviews.llvm.org/D148548
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
