[Lldb-commits] [PATCH] D148400: [lldb] Fix bug to update process public run lock with process state

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/source/Target/Process.cpp:404-414
+llvm::StringRef Process::GetAttachSynchronousHijackListenerName() {
+  return "lldb.internal.Process.AttachSynchronous.hijack";
+}
+
+llvm::StringRef Process::GetLaunchSynchronousHijackListenerName() {
+  return "lldb.internal.Process.LaunchSynchronous.hijack";
+}
----------------
Do these actually need to be methods? Can't these be public static `StringRef`s 
instead?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148400/new/

https://reviews.llvm.org/D148400

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits