sgraenitz added a comment. Addressed feedback and added handling for `R_ARM_REL32`. I didn't see a real-world case for it yet. Hope it's ok to have the error reported for the time being.
================ Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2640 +static void ApplyELF32ABS32Relocation(Symtab *symtab, ELFRelocation &rel, + DataExtractor &debug_data, ---------------- peter.smith wrote: > IIUC the largest difference between this and ApplyELF64ABS32Relocation is > the use of REL rather than RELA relocations. Perhaps worth naming it as > `ApplyELF32ABS32RelRelocation` Thanks, very good point. Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147642/new/ https://reviews.llvm.org/D147642 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
