JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM modulo naming preference
================
Comment at: lldb/include/lldb/Target/Process.h:287-292
+ bool CurrentlyRunningExpression() const {
+ // Don't return true if we are no longer running an expression:
+ if (m_running_user_expression || m_running_utility_function)
+ return true;
+ return false;
+ }
----------------
I would prefer `IsRunningExpression` for consistency with other `IsFoo`
methods. It still conveys that the process is in the process of executing an
expression. /end bikeshedding
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147587/new/
https://reviews.llvm.org/D147587
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
