AryanGodara created this revision.
Herald added a reviewer: bollu.
Herald added subscribers: steakhal, martong, arphaman.
Herald added a reviewer: aaron.ballman.
Herald added a reviewer: NoQ.
Herald added a project: All.
AryanGodara requested review of this revision.
Herald added projects: clang, LLDB, LLVM.
Herald added subscribers: llvm-commits, lldb-commits, cfe-commits.
Signed-off-by: aryan <aryangodar...@gmail.com>
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D146041
Files:
clang/include/clang/Basic/DiagnosticCommonKinds.td
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/lib/Sema/SemaDeclAttr.cpp
clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp
clang/test/CXX/drs/dr16xx.cpp
clang/test/Lexer/SourceLocationsOverflow.c
clang/test/SemaTemplate/temp_arg_nontype_cxx20.cpp
clang/unittests/Format/FormatTest.cpp
clang/www/demo/index.cgi
lldb/examples/synthetic/libcxx.py
llvm/include/llvm/CodeGen/MachinePassManager.h
llvm/tools/bugpoint/ExecutionDriver.cpp
llvm/tools/bugpoint/ExtractFunction.cpp
llvm/utils/check-each-file
polly/lib/External/isl/imath/tests/test.sh
Index: polly/lib/External/isl/imath/tests/test.sh
===================================================================
--- polly/lib/External/isl/imath/tests/test.sh
+++ polly/lib/External/isl/imath/tests/test.sh
@@ -9,8 +9,8 @@
set -o pipefail
if [ ! -f ../imtest ] ; then
- echo "I can't find the imath test driver 'imtest', did you build it?"
- echo "I can't proceed with the unit tests until you do so, sorry."
+ echo "The imath test driver 'imtest' was not found."
+ echo "It needs to be build before proceeding with the unit tests."
exit 2
fi
@@ -25,8 +25,8 @@
echo ""
echo "-- Running test to compute 1024 decimal digits of pi"
if [ ! -f ../pi ] ; then
- echo "I can't find the pi computing program, did you build it?"
- echo "I can't proceed with the pi test until you do so, sorry."
+ echo "The pi computing program was not found."
+ echo "It needs to be built before proceeding with the pi test."
exit 1
fi
Index: llvm/utils/check-each-file
===================================================================
--- llvm/utils/check-each-file
+++ llvm/utils/check-each-file
@@ -120,7 +120,7 @@
$linker
if $checker
then
- echo "Sorry, I can't help you, $program is OK when compiled with llvm-native-gcc"
+ echo "I cannot help you, $program is OK when compiled with llvm-native-gcc"
exit 1
fi
for f in $files
Index: llvm/tools/bugpoint/ExtractFunction.cpp
===================================================================
--- llvm/tools/bugpoint/ExtractFunction.cpp
+++ llvm/tools/bugpoint/ExtractFunction.cpp
@@ -119,7 +119,7 @@
Passes.push_back("verify");
std::unique_ptr<Module> New = runPassesOn(Clone.get(), Passes);
if (!New) {
- errs() << "Instruction removal failed. Sorry. :( Please report a bug!\n";
+ errs() << "Instruction removal failed. Please report a bug!\n";
exit(1);
}
return New;
@@ -141,7 +141,7 @@
std::unique_ptr<Module> New = runPassesOn(M.get(), CleanupPasses);
if (!New) {
- errs() << "Final cleanups failed. Sorry. :( Please report a bug!\n";
+ errs() << "Final cleanups failed. Please report a bug!\n";
return nullptr;
}
return New;
@@ -155,7 +155,7 @@
if (!NewM) {
outs() << "*** Loop extraction failed: ";
EmitProgressBitcode(*M, "loopextraction", true);
- outs() << "*** Sorry. :( Please report a bug!\n";
+ outs() << "*** Please report a bug!\n";
return nullptr;
}
Index: llvm/tools/bugpoint/ExecutionDriver.cpp
===================================================================
--- llvm/tools/bugpoint/ExecutionDriver.cpp
+++ llvm/tools/bugpoint/ExecutionDriver.cpp
@@ -171,7 +171,7 @@
}
if (!Interpreter) {
InterpreterSel = AutoPick;
- Message = "Sorry, I can't automatically select an interpreter!\n";
+ Message = "I cannot automatically select an interpreter!\n";
}
break;
case RunLLI:
@@ -216,7 +216,7 @@
Path.c_str(), Message, CCBinary, &SafeToolArgs, &CCToolArgv);
} else if (InterpreterSel != CompileCustom) {
SafeInterpreterSel = AutoPick;
- Message = "Sorry, I can't automatically select a safe interpreter!\n";
+ Message = "I cannot automatically select a safe interpreter!\n";
}
break;
case RunLLC:
@@ -231,7 +231,7 @@
getToolName(), Message, CustomExecCommand);
break;
default:
- Message = "Sorry, this back-end is not supported by bugpoint as the "
+ Message = "This back-end is not supported by bugpoint as the "
"\"safe\" backend right now!\n";
break;
}
Index: llvm/include/llvm/CodeGen/MachinePassManager.h
===================================================================
--- llvm/include/llvm/CodeGen/MachinePassManager.h
+++ llvm/include/llvm/CodeGen/MachinePassManager.h
@@ -226,7 +226,7 @@
addRunOnModule(PassConceptT *Pass) {
static_assert(is_detected<is_machine_function_pass_t, PassT>::value,
"machine module pass needs to define machine function pass "
- "api. sorry.");
+ "api.");
using PassModelT =
detail::PassModel<MachineFunction, PassT, PreservedAnalyses,
Index: lldb/examples/synthetic/libcxx.py
===================================================================
--- lldb/examples/synthetic/libcxx.py
+++ lldb/examples/synthetic/libcxx.py
@@ -609,7 +609,7 @@
if self.get_child_at_index(0):
return self.get_child_at_index(index)
else:
- logger >> "item == 0 could not be found. sorry, nothing can be done here."
+ logger >> "item == 0 could not be found. Nothing can be done here."
return None
return current.CreateChildAtOffset(
'[' + str(index) + ']', self.skip_size, self.data_type)
Index: clang/www/demo/index.cgi
===================================================================
--- clang/www/demo/index.cgi
+++ clang/www/demo/index.cgi
@@ -270,7 +270,7 @@
alarm 0;
};
if ( $@ and $@ =~ /timeout/ ) {
- barf("Program $program took too long, compile time limited for the web script, sorry!\n");
+ barf("Program $program took too long, compile time limited for the web script.\n");
}
if ( -s $outputFile ) {
print scalar dumpFile( "Output from $program", $outputFile );
@@ -286,7 +286,7 @@
if ( WIFSIGNALED($retcode) != 0 ) {
my $sig = WTERMSIG($retcode);
barf(
- "Ouch, $program caught signal $sig. Sorry, better luck next time!\n"
+ "Ouch, $program caught signal $sig.\n"
);
}
}
Index: clang/unittests/Format/FormatTest.cpp
===================================================================
--- clang/unittests/Format/FormatTest.cpp
+++ clang/unittests/Format/FormatTest.cpp
@@ -11423,12 +11423,12 @@
verifyFormat("SomeType s [[gnu::unused]] (InitValue);");
verifyFormat("SomeType s [[using gnu: unused]] (InitValue);");
verifyFormat("[[gsl::suppress(\"clang-tidy-check-name\")]] void f() {}");
- verifyFormat("void f() [[deprecated(\"so sorry\")]];");
+ verifyFormat("void f() [[deprecated]];");
verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
" [[unused]] aaaaaaaaaaaaaaaaaaaaaaa(int i);");
verifyFormat("[[nodiscard]] bool f() { return false; }");
verifyFormat("class [[nodiscard]] f {\npublic:\n f() {}\n}");
- verifyFormat("class [[deprecated(\"so sorry\")]] f {\npublic:\n f() {}\n}");
+ verifyFormat("class [[deprecated]] f {\npublic:\n f() {}\n}");
verifyFormat("class [[gnu::unused]] f {\npublic:\n f() {}\n}");
verifyFormat("[[nodiscard]] ::qualified_type f();");
@@ -22880,10 +22880,10 @@
EXPECT_EQ(FormatStyle::LK_ObjC,
guessLanguage("foo.h", "array[[calculator getIndex]];"));
EXPECT_EQ(FormatStyle::LK_Cpp,
- guessLanguage("foo.h", "[[noreturn, deprecated(\"so sorry\")]];"));
+ guessLanguage("foo.h", "[[noreturn, deprecated]];"));
EXPECT_EQ(
FormatStyle::LK_Cpp,
- guessLanguage("foo.h", "[[noreturn, deprecated(\"gone, sorry\")]];"));
+ guessLanguage("foo.h", "[[noreturn, deprecated]];"));
EXPECT_EQ(FormatStyle::LK_ObjC,
guessLanguage("foo.h", "[[noreturn foo] bar];"));
EXPECT_EQ(FormatStyle::LK_Cpp,
Index: clang/test/SemaTemplate/temp_arg_nontype_cxx20.cpp
===================================================================
--- clang/test/SemaTemplate/temp_arg_nontype_cxx20.cpp
+++ clang/test/SemaTemplate/temp_arg_nontype_cxx20.cpp
@@ -8,8 +8,8 @@
// floating-point arguments
template<float> struct Float {};
-using F1 = Float<1.0f>; // FIXME expected-error {{sorry}}
-using F1 = Float<2.0f / 2>; // FIXME expected-error {{sorry}}
+using F1 = Float<1.0f>; // FIXME expected-error
+using F1 = Float<2.0f / 2>; // FIXME expected-error
struct S { int n[3]; } s; // expected-note 1+{{here}}
union U { int a, b; } u;
@@ -48,12 +48,12 @@
// miscellaneous scalar types
template<_Complex int> struct ComplexInt {};
-using CI = ComplexInt<1 + 3i>; // FIXME: expected-error {{sorry}}
-using CI = ComplexInt<1 + 3i>; // FIXME: expected-error {{sorry}}
+using CI = ComplexInt<1 + 3i>; // FIXME: expected-error
+using CI = ComplexInt<1 + 3i>; // FIXME: expected-error
template<_Complex float> struct ComplexFloat {};
-using CF = ComplexFloat<1.0f + 3.0fi>; // FIXME: expected-error {{sorry}}
-using CF = ComplexFloat<1.0f + 3.0fi>; // FIXME: expected-error {{sorry}}
+using CF = ComplexFloat<1.0f + 3.0fi>; // FIXME: expected-error
+using CF = ComplexFloat<1.0f + 3.0fi>; // FIXME: expected-error
namespace ClassNTTP {
struct A { // expected-note 2{{candidate}}
Index: clang/test/Lexer/SourceLocationsOverflow.c
===================================================================
--- clang/test/Lexer/SourceLocationsOverflow.c
+++ clang/test/Lexer/SourceLocationsOverflow.c
@@ -1,6 +1,6 @@
// RUN: not %clang %s -S -o - 2>&1 | FileCheck %s
// CHECK: In file included from {{.*}}SourceLocationsOverflow.c
-// CHECK-NEXT: inc1.h{{.*}}: fatal error: sorry, this include generates a translation unit too large for Clang to process.
+// CHECK-NEXT: inc1.h{{.*}}: fatal error: this include generates a translation unit too large for Clang to process.
// CHECK-NEXT: #include "inc2.h"
// CHECK-NEXT: ^
// CHECK-NEXT: note: 214{{.......}}B in local locations, 0B in locations loaded from AST files, for a total of 214{{.......}}B (99% of available space)
Index: clang/test/CXX/drs/dr16xx.cpp
===================================================================
--- clang/test/CXX/drs/dr16xx.cpp
+++ clang/test/CXX/drs/dr16xx.cpp
@@ -392,7 +392,7 @@
#if __cplusplus < 201402L
// expected-note@-2 {{first required here}}
#else
- // expected-warning-re@-4 {{sorry, lifetime extension {{.*}} not supported}}
+ // expected-warning-re@-4 {{lifetime extension {{.*}} not supported}}
#endif
struct D2 {
Index: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp
===================================================================
--- clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp
+++ clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp
@@ -1212,7 +1212,6 @@
} else {
StringRef Note = Case.getNote();
const NoteTag *Tag = C.getNoteTag(
- // Sorry couldn't help myself.
[Node, Note]() -> std::string {
// Don't emit "Assuming..." note when we ended up
// knowing in advance which branch is taken.
Index: clang/lib/Sema/SemaDeclAttr.cpp
===================================================================
--- clang/lib/Sema/SemaDeclAttr.cpp
+++ clang/lib/Sema/SemaDeclAttr.cpp
@@ -9558,7 +9558,7 @@
AttributeCommonInfo::AS_Pragma));
WeakTopLevelDecl.push_back(NewD);
// FIXME: "hideous" code from Sema::LazilyCreateBuiltin
- // to insert Decl at TU scope, sorry.
+ // to insert Decl at TU scope.
DeclContext *SavedContext = CurContext;
CurContext = Context.getTranslationUnitDecl();
NewD->setDeclContext(CurContext);
Index: clang/include/clang/Basic/DiagnosticSemaKinds.td
===================================================================
--- clang/include/clang/Basic/DiagnosticSemaKinds.td
+++ clang/include/clang/Basic/DiagnosticSemaKinds.td
@@ -4986,7 +4986,7 @@
def err_non_type_template_arg_addr_label_diff : Error<
"template argument / label address difference / what did you expect?">;
def err_non_type_template_arg_unsupported : Error<
- "sorry, non-type template argument of type %0 is not yet supported">;
+ "non-type template argument of type %0 is not yet supported">;
def err_template_arg_not_convertible : Error<
"non-type template argument of type %0 cannot be converted to a value "
"of type %1">;
@@ -5039,7 +5039,7 @@
def err_template_arg_not_pointer_to_member_form : Error<
"non-type template argument is not a pointer to member constant">;
def err_template_arg_member_ptr_base_derived_not_supported : Error<
- "sorry, non-type template argument of pointer-to-member type %1 that refers "
+ "non-type template argument of pointer-to-member type %1 that refers "
"to member %q0 of a different class is not supported yet">;
def err_template_arg_invalid : Error<
"non-type template argument '%0' is invalid">;
@@ -9663,7 +9663,7 @@
"will be destroyed at the end of the full-expression">,
InGroup<DanglingInitializerList>;
def warn_unsupported_lifetime_extension : Warning<
- "sorry, lifetime extension of "
+ "lifetime extension of "
"%select{temporary|backing array of initializer list}0 created "
"by aggregate initialization using default member initializer "
"is not supported; lifetime of %select{temporary|backing array}0 "
Index: clang/include/clang/Basic/DiagnosticCommonKinds.td
===================================================================
--- clang/include/clang/Basic/DiagnosticCommonKinds.td
+++ clang/include/clang/Basic/DiagnosticCommonKinds.td
@@ -335,9 +335,9 @@
def err_file_modified : Error<
"file '%0' modified since it was first processed">, DefaultFatal;
def err_file_too_large : Error<
- "sorry, unsupported: file '%0' is too large for Clang to process">;
+ "unsupported: file '%0' is too large for Clang to process">;
def err_include_too_large : Error<
- "sorry, this include generates a translation unit too large for"
+ "this include generates a translation unit too large for"
" Clang to process.">, DefaultFatal;
def err_unsupported_bom : Error<"%0 byte order mark detected in '%1', but "
"encoding is not supported">, DefaultFatal;
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
