bolshakov-a added inline comments.
================ Comment at: clang/lib/Index/USRGeneration.cpp:1032 + case TemplateArgument::UncommonValue: + // FIXME: Visit value. + break; ---------------- bnbarham wrote: > akyrtzi wrote: > > erichkeane wrote: > > > bolshakov-a wrote: > > > > aaron.ballman wrote: > > > > > Any particular reason this isn't being handled now? > > > > I need some guidance here. Which characters are allowed in the USR? > > > > Could the mangling algorithm from > > > > `CXXNameMangler::mangleValueInTemplateArg` be moved into some common > > > > place and reused here? > > > I have no idea what is valid here. BUT @akyrtzi and @gribozavr (or > > > @gribozavr2 ?) seem to be the ones that touch these files the most? > > Adding @bnbarham to review the `Index` changes. > Just visiting the underlying type seems reasonable, ie. > `VisitType(Arg.getUncommonValueType());`. If it needed to be differentiated > between a `TemplateArgument::Type` you could add a prefix character (eg. > `U`), but that doesn't seem needed to me. Doesn't the holded value be added so as to distinguish e.g. `Tpl<1.5>` from `Tpl<2.5>`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
