jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
LGTM. I'm not really advocating to changing `m_type` to be an enum, but
curious how that might fit into the total context of this feature, and if it
makes any sense.
================
Comment at: lldb/include/lldb/Target/RegisterFlags.h:70
+ // We do not expect to see another flags type here.
+ std::string m_type;
+ };
----------------
Should we store the type as an eFormat enum instead of a string? Maybe it's
just informational for logging/humans and not too important.
ProcessGDBRemote::BuildDynamicRegisterInfo translates our own register type
names into these values (more often seen in the old lldb-created
`qRegisterInfo`s).
================
Comment at: lldb/source/Target/RegisterFlags.cpp:49
+ : m_id(id.str()), m_size(size) {
+ // We expect that the XML processor will discard anything decsribing flags
but
+ // with no fields.
----------------
describing
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145566/new/
https://reviews.llvm.org/D145566
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
