mib accepted this revision.
mib added a comment.
This revision is now accepted and ready to land.
LGTM with a comment.
================
Comment at: lldb/source/Core/ValueObject.cpp:1862
}
- if (m_dynamic_value)
+ if (m_dynamic_value && m_dynamic_value->GetError().Success())
return m_dynamic_value->GetSP();
----------------
It would be nice if `ValueObjectDynamicValue` had a `IsValid` method that
returned the result of its Status attribute. Without reading the commit
message, `GetError` doesn't tell us much about what we're trying to achieve
here.
================
Comment at: lldb/source/Core/ValueObjectConstResult.cpp:290
}
- if (m_dynamic_value)
+ if (m_dynamic_value && m_dynamic_value->GetError().Success())
return m_dynamic_value->GetSP();
----------------
ditto
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145629/new/
https://reviews.llvm.org/D145629
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
