JDevlieghere added a comment. You're passing `is_callback` by value so the `const` is close to redundant. I think there's an "Effective C++" chapter dedicated to this. LLVM is pretty conservative in marking this as `const` and while LLDB uses it a bit more this isn't common at all. The current code now makes you wonder why this is different than `has_extra_args`. Even if that does get modified in some of the function's implementation, that's an implementation detail that shouldn't be exposed through the interface.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144688/new/ https://reviews.llvm.org/D144688 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
