jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land.
LGTM ================ Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:119 } + +llvm::ArrayRef<OptionDefinition> ---------------- jingham wrote: > There's a version of Append that lets you exclude and remap option sets. > This seems like a finer-grained version of the same thing where you just want > to exclude particular options by name but not mess with the option sets. > That seems a generally useful thing to do, so it would be better to make > another flavor of Append that takes an array of short character options and > just excludes them, than do it as a one-off here. That would also make this code easier to read, since the exclusion would happen where you added it rather than way down below. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144114/new/ https://reviews.llvm.org/D144114 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
