mib marked an inline comment as done.
mib added inline comments.
================
Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:310-311
+size_t ScriptedProcess::DoWriteMemory(lldb::addr_t vm_addr, const void *buf,
+ size_t size, Status &error) {
+ lldb::DataExtractorSP data_extractor_sp = std::make_shared<DataExtractor>(
----------------
bulbazord wrote:
> This function is added in this patch. Where is it used?
`Plugin::DoX` functions are usually implemented by plugins and gets called by
the base component `Base::X` method. In this case, this will get called by the
`Process::WriteMemory` method.
================
Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:325
+
+ return size;
+}
----------------
bulbazord wrote:
> Should this not return `bytes_written`?
+1
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144237/new/
https://reviews.llvm.org/D144237
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
