bulbazord added a reviewer: jingham. bulbazord requested changes to this revision. bulbazord added a comment. This revision now requires changes to proceed.
I'm alright with the implementation, but I think you should add some documentation here. Also, what do you think of the name `WriteMemoryAsCString`? To make it clear that whatever you are passing will be written to memory as a cstring. ================ Comment at: lldb/bindings/interface/SBProcessExtensions.i:5-9 + def WriteCStringToMemory(self, addr, str, error): + if not str[-1] == '\0': + str += '\0' + return self.WriteMemory(addr, str, error) + ---------------- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144224/new/ https://reviews.llvm.org/D144224 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
