bulbazord added inline comments.

================
Comment at: lldb/tools/debugserver/source/debugserver.cpp:1342
 
     DNBLogSetLogMask(log_flags);
   }
----------------
jasonmolenda wrote:
> Should this be moved out of this `log_file != NULL` block so that the logging 
> flags are set based on `-f` value?  Otherwise looks good to me.
Good catch, that is indeed the case. I'll update this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144142/new/

https://reviews.llvm.org/D144142

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to