[Lldb-commits] [PATCH] D143932: Further delay simulator SDK filepath discovery until needed

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

LGTM with the `std::move`.



================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp:50-51
       m_os_type(preferred_os), m_supported_triples(supported_triples),
-      m_sdk(sdk), m_sdk_type(sdk_type) {}
+      m_sdk_name_primary(sdk_name_primary),
+      m_sdk_name_secondary(sdk_name_secondary), m_sdk_type(sdk_type) {}
 
----------------
Use `std::move` to avoid a needles copy.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143932/new/

https://reviews.llvm.org/D143932

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits