JDevlieghere added a comment.
I left a few nits here and there but overall this LGTM
================
Comment at: lldb/include/lldb/Interpreter/OptionArgParser.h:19-20
struct OptionArgParser {
+ // Try to parse an address. If it succeeds return the address with the
+ // non-address bits removed.
static lldb::addr_t ToAddress(const ExecutionContext *exe_ctx,
----------------
================
Comment at: lldb/include/lldb/Interpreter/OptionArgParser.h:25
+
+ // As for ToAddress but do not remove non-address bits from the result.
+ static lldb::addr_t ToRawAddress(const ExecutionContext *exe_ctx,
----------------
================
Comment at: lldb/source/Interpreter/OptionArgParser.cpp:161-162
+
+ Process *process = exe_ctx->GetProcessPtr();
+ if (process)
+ if (ABISP abi_sp = process->GetABI())
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142715/new/
https://reviews.llvm.org/D142715
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
