bulbazord added a comment.

This is an interesting idea.

I suppose I find it a little strange that something from the SB API is passing 
a void * back to the caller instead of something more well defined (like 
another SB class or some primitive) but I suppose that's not the worst thing in 
the world. I'm not sure how else you would get a C++ method to return a type 
that is dependent on which language the method was called from...



================
Comment at: lldb/bindings/interface/SBProcess.i:347-348
 
+    void*
+    GetImplementation();
+
----------------
Maybe a docstring is in order? Something to explain how to use this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143236/new/

https://reviews.llvm.org/D143236

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to