mib marked 2 inline comments as done.
mib added inline comments.
================
Comment at: lldb/examples/python/crashlog.py:452
- with open(path, 'r', encoding='utf-8') as f:
+ with open(os.path.normpath(os.path.expanduser(path)), 'r',
encoding='utf-8') as f:
buffer = f.read()
----------------
mib wrote:
> JDevlieghere wrote:
> > It's not obvious why this is necessary (and we can't rely on open/the OS to
> > do this for us) so let's add a comment.
> From my experience, `open`
I started replying to your message but I ended up adding a comment of the file
directly.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141658/new/
https://reviews.llvm.org/D141658
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
