mib added a comment.

I'm very excited about this :) ! We've already discussed that offline but it 
would be nice if we could use Doxygen comments in the header files to generate 
the python Docstrings (I'm pretty sure SWIG supports it).

Then, for python specific comments, we would have a separate documentation 
file. Also, naming-wise, since the file extension doesn't really matter for 
SWIG, I'd just match the header file name and change the extension (what about 
`.i` for the code specific to the target language and `.rst` for the 
documentation).



================
Comment at: lldb/bindings/macros.swig:35-36
+// STRING_EXTENSION entirely.
+%define STRING_EXTENSION_OUTSIDE(Class)
+%extend lldb:: ## Class ## {
+  std::string __repr__(){
----------------
Pretty cool!


================
Comment at: lldb/cmake/modules/LLDBFramework.cmake:91
     DEPENDS ${header} OUTPUT ${staged_header}
-    COMMAND ${CMAKE_COMMAND} -E copy ${header} ${staged_header}
-    COMMENT "LLDB.framework: collect framework header")
+    COMMAND unifdef -USWIG -o ${staged_header} ${header} || (exit 0)
+    COMMENT "LLDB.framework: collect framework header and remove SWIG macros")
----------------
May be we should add a cmake check to make sure `unidef` is available on the 
system.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142926/new/

https://reviews.llvm.org/D142926

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to