jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
I don't think this code is going to compile, is it? You took out the `if
(!buffer) {` but left the RHS `}` so now the scopes are unbalanced. I think
you should just change how the shared pointer is defined - which is presumably
the substance of the patch - and leave everything after as is.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142309/new/
https://reviews.llvm.org/D142309
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
