Michael137 added inline comments.

================
Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:225
   if (valobj_sp)
+    SyntheticChildrenFrontEnd(*valobj_sp);
     Update();
----------------
Michael137 wrote:
> this won't initialise the parent constructor though will it? Just creates a 
> temporary and immediately destructs it? You might need to put it back into 
> the initialiser list and use a ternary
Oh but `SyntheticChildrenFrontEnd` seems to always take a reference. The 
interfaces seem to be a little mismatched


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142341/new/

https://reviews.llvm.org/D142341

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to