clayborg added a comment. In D68655#4045420 <https://reviews.llvm.org/D68655#4045420>, @clayborg wrote:
> SymbolVendorELF.cpp is using this as well: > > dsym_objfile_sp->SetType(ObjectFile::eTypeDebugInfo); > > They must have copied and pasted some code. So not sure this is safe enough > as is to implement. There are also a few places that try to check for a dSYM > file using this kind of method, might be nice to add a method, that is done > right, that detects if we really have a dSYM or not in ObjectFile.h/.cpp. > Wasm also sets the file type to debug info and so does breakpad. The best way to check for dSYM would be to read the bytes from the mach-o header that specify MH_DSYM from the data for the object file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68655/new/ https://reviews.llvm.org/D68655 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
