aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
I think it makes sense to have one test that tests the `p` command alias and
its parameter handling and have all other tests be explicit about whether they
test the expression evaluator or the command alias. As such, this is a good
canonicalization.
================
Comment at: lldb/test/API/python_api/file_handle/TestFileHandle.py:138
self.dbg.SetOutputFileHandle(f, False)
- self.handleCmd('p/x 3735928559', collect_result=False, check=False)
+ self.handleCmd('expression/x 3735928559', collect_result=False,
check=False)
with open(self.out_filename, 'r') as f:
----------------
not your code, but does the `/x` serve any purpose here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141539/new/
https://reviews.llvm.org/D141539
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
