nikic added a comment. Just to check, this isn't going to cause some warning spew about all those OptTable implementations being non-final?
================ Comment at: llvm/include/llvm/Option/OptTable.h:256 +/// Specialization of +class GenericOptTable : public OptTable { ---------------- Comment looks a bit unfinished :) ================ Comment at: llvm/unittests/Option/OptionParsingTest.cpp:87 + +template <typename T> class DISABLED_OptTableTest : public ::testing::Test {}; + ---------------- What's this about? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140800/new/ https://reviews.llvm.org/D140800 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits